Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group Parameter containers in container module #1044

Merged
merged 5 commits into from
Feb 10, 2021
Merged

Group Parameter containers in container module #1044

merged 5 commits into from
Feb 10, 2021

Conversation

jrapin
Copy link
Contributor

@jrapin jrapin commented Feb 10, 2021

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Motivation and Context / Related issue

following #1043 containers can now be gathered in the same module

How Has This Been Tested (if it applies)

Checklist

  • The documentation is up-to-date with the changes I made.
  • I have read the CONTRIBUTING document and completed the CLA (see CLA).
  • All tests passed, and additional code has been covered with new tests.

@jrapin jrapin self-assigned this Feb 10, 2021
@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 10, 2021
@jrapin jrapin changed the title Gather Parameter containers together Gather Parameter containers in container module Feb 10, 2021
@jrapin jrapin changed the title Gather Parameter containers in container module Group Parameter containers in container module Feb 10, 2021
@jrapin jrapin merged commit 1880ea2 into facebookresearch:master Feb 10, 2021
@jrapin jrapin deleted the move_parameters branch February 10, 2021 23:41
@dependabot dependabot bot mentioned this pull request Mar 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jrapin jrapin

Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Difficulty: Low Priority: High
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jrapin @facebook-github-bot